Skip to content

harden: add output encoding in index.js (CWE-79) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupamme wants to merge 1 commit into from
Closed

harden: add output encoding in index.js (CWE-79) #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions template/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ const { html } = require('es5-lit-element')
const { render } = require('es5-lit-html')
const config = window.__config || {}

// Only allow http(s) URLs from untrusted external data to prevent
// javascript: URI based XSS via href attributes
function safeUrl (url) {
return /^https?:\/\//i.test(url) ? url : '#'
}

// Import custom elements
require('./page')
require('./project-list')
Expand Down Expand Up @@ -84,7 +90,7 @@ require('nighthawk')({
<a href="https://www.github.com/${issue.project.repoOwner}" target="_blank">${issue.project.repoOwner}</a>
/ <a href="https://www.github.com/${issue.project.repo}" target="_blank">${issue.project.repoName}</a>
</span>
<a href="${issue.issue.url}" target="_blank" class="issue-title">${issue.issue.title}</a>
<a href="${safeUrl(issue.issue.url)}" target="_blank" class="issue-title">${issue.issue.title}</a>
</li>
`
})}
Expand Down Expand Up @@ -138,7 +144,7 @@ require('nighthawk')({
<a href="https://www.github.com/${issue.project.repoOwner}" target="_blank">${issue.project.repoOwner}</a>
/ <a href="${issue.project.repo}" target="_blank">${issue.project.repoName}</a>
</span>
<a href="${issue.issue.url}" target="_blank" class="issue-title">${issue.issue.title}</a>
<a href="${safeUrl(issue.issue.url)}" target="_blank" class="issue-title">${issue.issue.title}</a>
</li>
`)}
</ul>
Expand All @@ -165,7 +171,7 @@ require('nighthawk')({
<a href="https://www.github.com/${issue.project.repoOwner}" target="_blank">${issue.project.repoOwner}</a>
/ <a href="${issue.project.repo}" target="_blank">${issue.project.repoName}</a>
</span>
<a href="${issue.issue.url}" target="_blank" class="issue-title">${issue.issue.title}</a>
<a href="${safeUrl(issue.issue.url)}" target="_blank" class="issue-title">${issue.issue.title}</a>
</li>
`)}
</ul>
Expand Down