Fix select queries using custom scopes#408
Open
thisismydesign wants to merge 1 commit intoplatanus:masterfrom
Open
Fix select queries using custom scopes#408thisismydesign wants to merge 1 commit intoplatanus:masterfrom
thisismydesign wants to merge 1 commit intoplatanus:masterfrom
Conversation
Author
|
CI failure:
|
Author
|
@ldlsegovia any chance you can take a look at this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407
AFAICT the following queries are equivalent:
Simplifying the query sent to
activeadminallows for custom scopes to be used in ajax select fields. It also simplifies the query :)I didn't modify nested_select, I suspect that this implementation with grouping was made for that use case and then re-used for the more simple ones.