[FEA-1057] Nfts #57
Open
[FEA-1057] Nfts #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will resolves issues with submodule |
ungaro
added a commit
that referenced
this pull request
Jun 18, 2025
ungaro
added a commit
that referenced
this pull request
Jul 16, 2025
* v2 fixes * Expired Votes Not Properly Filtered #55 * formatting * Unnecessary Storage Reads #64 * Duplicate Storage Variables #63 * No New Reward Checkpoint on Token Remove #50 * Votes Can Be Cleaned Up to Avoid Slashing #54 * Duplicate timestamp Commission Checkpoints Can Lead to Theft #46 * Incorrect totalCooling Decrease on Slashing #57 * Commission Might Be Able to Claim Before Slashing Period Ends #51 * Excessive Commission Changes Can Lock Funds #45 * Missing Constant Initialization #58 * Validator Commission Checks Not Enforced on maxAllowedValidatorCommission Update #61 * Validator Creation Can Be Blocked From Being Created #53 * maxValidatorPercentage Is Ineffective #59 * formatting * OS-PLM-SUG-00 Missing Total Claimable State Update * fix(rewards): Enforce initial rate on token addition and fix re-addition bug * refactor: Simplify reward logic by removing redundant validator state checks * fix: Close slashing bypass loophole in restake function * fix(security): Prevent slashed validators from finalizing commission claims * fix: Align vote expiration logic to prevent off-by-one error * fix: Reorder slashed/inactive validator checks in updateRewardPerTokenForValidator * fix(slashing): Preserve valid cooldowns during admin cleanup * refactor(rewards): Make getUserLastCheckpointIndex dynamic * refactor(rewards): Overhaul reward calculation for accuracy and robustness * fix: first staker in _validateValidatorPercentage * feat(rewards): Add historical token management and fix reward loss bug * fix: inactive validator rewards * fix setMaxRewardRate to behave like setMaxAllowedValidatorCommission * fix: _calculateActivelyCoolingAmount & _countActiveCooldowns cooldowns from slashed validators * fix: transfer rewards fromn treasury during restakerewards * add migration functions * formatting * update readme * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Add PlumeGoon and PlumePassport
do -
forge install dmfxyz/murky --no-committo run tests