Repository navigation
Fix source-verified sample metadata under samples and scenarios - #282
VesaJuvonen wants to merge 1 commit into
Conversation
Repair declarations using committed packages and locks; add historical NewsFeed metadata and correct existing descriptions, date and asset paths. Preserve non-SPFx facts and artifact-only exclusions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Validation failed!File: samples/ImageCard-HTML-React-Stock-Price-Chart/assets/sample.json
File: samples/ImageCard-MostLikedPages/assets/sample.json
File: samples/ImageCard-HybridWork-Checkin/assets/sample.json
|
Validation failed!File: samples/ImageCard-MyLocation/assets/sample.json
File: samples/ImageCard-DynamicContentCard/assets/sample.json
File: samples/BasicCard-My-OneDrive-Info/assets/sample.json
File: samples/ImageCard-At-a-glance/assets/sample.json
File: samples/ImageCard-BookingSpaces/assets/sample.json
File: samples/ImageCard-PromotePages/assets/sample.json
File: samples/BasicCard-ShareGraphClient/assets/sample.json
File: samples/ImageCard-HTML-React-Stock-Price-Chart/assets/sample.json
File: samples/ImageCard-MostLikedPages/assets/sample.json
File: samples/ImageCard-HideACE/assets/sample.json
|
Merge stopped: normal checks are not greenThe committed metadata passes local strict JSON validation for all 64 changed files, the repository schema for all 85 gallery records, and the complete-snapshot audit (70 → 3 errors, zero new errors). I have not merged or bypassed checks. The existing sample-build workflow runs installations/builds even for metadata-only PRs. Confirmed blockers include:
The PnP metadata validator reports reachability failures for unchanged author-avatar URLs and an unchanged existing DynamicContentCard preview URL. Its two attempts failed different URL sets. All nine unique reported URLs returned HTTP 200 on direct HEAD inspection, and comparison against the source base confirms all 13 reported field occurrences are unchanged. This supports intermittent validator-side URL reachability/transport failures, not a patch-introduced metadata defect; the validator's network environment was not reproduced. One ordinary retry was already attempted; no further retry or speculative URL replacement was made. Its first-page-only coverage remains supplemented by complete local validation. All checks have now completed: 58 successful, seven failed (six sample builds plus metadata URL validation). Every one of the 64 changed files is Fixing these build failures would require code/dependency/workflow changes outside this metadata-only authorization, so none were made. The branch has no enforced required-status rules, but normal failing checks were not bypassed. Repository auto-merge is disabled ( |
714a3eb9a0cb53a4c3973d10ad8f3c2608fca624What's in this Pull Request?
Repair 64
assets/sample.jsonfiles under samples and scenarios only. No sample code, dependencies, lockfiles, workflows, screenshots, or gallery aggregate files are changed.1.19.beta0declaration using each sample's actual packages and committed package locks, not the newest available SPFx release.1.15.0-rc.0, Search FAQs1.20.0, calendar plan1.14.0, and PlannerTasks1.13.0-beta.20. ShareGraphClient's separate graph-client-library is correctly left at its independently declared/locked1.15.2; the metadata describes its two ACEs.Historical evidence
81ad320, 2022-04-26. The commit's GitHub author istechienickb; the README identifies Nick Brown and Jisc.d8330c0, 2026-08-11. Its package and lock both resolve SPFx1.23.0.06d123c. The impossible2024-01-21update already appeared in the original metadata addition,3c93381.Validation
templates/metadata-schema.jsonDraft 7 validation, including date formats: all 64 touched files pass.auditSnapshotrerun on an edited copy of the complete collected source snapshot: repository errors 70 → 3, metadata files/records 84 → 85, missing-metadata findings 2 → 1, zero newly introduced errors in any source.downloadUrl, like existing entries.git diff --checkpasses; existing file formatting is preserved.Deliberately not invented / remaining central-audit findings
samples/ImageCard-ApplyLeave-OOF-Holidayis artifact-only: all 142 tracked files are underlib/,release/,sharepoint/, ortemp/; there is no README, package.json, or source tree. It entered in2d9b359. Do not manufacture a separate gallery sample for this directory.BotPowered-BasicAce-CollectFeedbackandBotPowered-BasicAce-Tasksare documented .NET bot-powered ACEs, not SPFx projects. Their.csprojfiles targetnet6.0and reference Bot Framework4.21.2. ExistingBOT-FRAMEWORK-VERSION=bot40is preserved. The central auditor's mandatorySPFX-VERSIONrule is inapplicable; no fictitious SPFx value is added.There are no remaining preview errors in this repository's audited metadata after repairing the exact existing paths. Genuinely missing screenshots elsewhere remain deferred; this PR creates or replaces none.