MongoDB replica set support #5068
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| _type = Single; | ||
| } | ||
| else if (primaries > 0) |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
Copilot Autofix
AI about 6 hours ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
| { | ||
| _type = ReplicaSetWithPrimary; | ||
| } | ||
| else if (secondaries > 0 || !_setName.empty()) |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
Copilot Autofix
AI about 6 hours ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
| } | ||
|
|
||
| // Determine topology type | ||
| if (mongosCount > 0) |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
| { | ||
| _type = Sharded; | ||
| } | ||
| else if (standaloneCount > 0 && _servers.size() == 1) |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 9 hours ago
To fix the issue (comparison is always false because standaloneCount <= 0), you should remove or revise the check that tests whether standaloneCount > 0 && _servers.size() == 1 on line 303. If the design means standalone servers are not present in _servers at this point, then the branch is dead code and should be deleted. The best fix is to safely remove the conditional branch and any associated comments describing what happens if there's a standalone server, only if this doesn't affect overall functionality or logic elsewhere. Make this change only to the block on lines 303–308, being careful to preserve other functionality and comments.
No imports or new methods are needed.
| @@ -300,12 +300,12 @@ | ||
| { | ||
| _type = Sharded; | ||
| } | ||
| else if (standaloneCount > 0 && _servers.size() == 1) | ||
| { | ||
| // Single standalone server - treat as Single topology | ||
| // Standalone servers behave like a single primary for read preferences | ||
| _type = Single; | ||
| } | ||
| // else if (standaloneCount > 0 && _servers.size() == 1) | ||
| // { | ||
| // // Single standalone server - treat as Single topology | ||
| // // Standalone servers behave like a single primary for read preferences | ||
| // _type = Single; | ||
| // } | ||
| else if (primaries > 0) | ||
| { | ||
| _type = ReplicaSetWithPrimary; |
…osts from "hello" only to discover replica set hosts.
No description provided.