Skip to content

Support [if] shortcode fields recursively (magic-tags)#5471

Draft
JoryHogeveen wants to merge 22 commits intomainfrom
feature/5470-recursive-if-shortcode
Draft

Support [if] shortcode fields recursively (magic-tags)#5471
JoryHogeveen wants to merge 22 commits intomainfrom
feature/5470-recursive-if-shortcode

Conversation

@JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Sep 17, 2019 •
edited
Loading

Fixes: #5470

Description

Add support for recursive if shortcodes for relationship fields. Example:

  • [if relationship.relationship_field] content [/if]
  • [if relationship.sub_relationship.sub_relationship_field] content [/if]

TODO

  • [if] (confirmed on Slack by Adam Spelbring): 2021-04-06)
  • [each]

ChangeLog

  • Enhancement: Support [if] and [each] shortcode tags recursively (magic-tags)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
  • My code includes automated tests for PHP and/or JS (if applicable).

@JoryHogeveen JoryHogeveen added Status: Need Dev Feedback Waiting on feedback from developer of PR Status: PR > QA pending QA needs to be done labels Sep 17, 2019
@JoryHogeveen JoryHogeveen added this to the Pods 2.7.16 milestone Sep 17, 2019
@JoryHogeveen JoryHogeveen self-assigned this Sep 17, 2019
@JoryHogeveen JoryHogeveen added the Status: In Progress Issue or PR is currently in progress but not yet done label Sep 17, 2019
@JoryHogeveen
Copy link
Member Author

JoryHogeveen commented Sep 17, 2019

@jimtrue @sc0ttkclark
Also see issue #5470

This PR will need a thorough testing round with all kings of shortcode and template usages (widgets??)
I'm not sure about the current extend of possibilities with this area of Pods so I can imagine I'm overlooking some features that need testing as well.

@sc0ttkclark especially this part: https://github.com/pods-framework/pods/pull/5471/files#diff-ab22a13affdb28c998776e73a1808abfR579-R585

@JoryHogeveen JoryHogeveen added the Status: PR > Pending Code Review PR is pending code review by core developers label Oct 24, 2019
sc0ttkclark
sc0ttkclark previously approved these changes Oct 25, 2019
View reviewed changes
@sc0ttkclark sc0ttkclark added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) and removed Status: PR > Pending Code Review PR is pending code review by core developers Status: Need Dev Feedback Waiting on feedback from developer of PR labels Oct 25, 2019
tr1b0t
tr1b0t reviewed Oct 25, 2019
View reviewed changes
Copy link

@tr1b0t tr1b0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 8 error(s)
⚠️ 2 warning(s)

tr1b0t
tr1b0t reviewed Nov 4, 2019
View reviewed changes
Copy link

@tr1b0t tr1b0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 4 error(s)

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.16, Pods 2.7.17 Nov 12, 2019
sc0ttkclark
sc0ttkclark reviewed Feb 10, 2020
View reviewed changes
@sc0ttkclark sc0ttkclark added this to the Pods 2.7.28 milestone Apr 16, 2021
@JoryHogeveen JoryHogeveen added Status: PR > QA pass QA passed and removed Status: PR > QA pending QA needs to be done labels Apr 19, 2021
@JoryHogeveen JoryHogeveen marked this pull request as ready for review April 19, 2021 17:23
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.28, Pods 2.7.29 May 19, 2021
sc0ttkclark
sc0ttkclark reviewed May 19, 2021
View reviewed changes
components/Templates/includes/functions-view_template.php
$field_data = $pod->field( $atts['field'] );

$field_type = $pod->fields( $atts['field'], 'type' );
/**
Copy link
Member

@sc0ttkclark sc0ttkclark May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the changes at https://github.com/pods-framework/pods/pull/5471/files#diff-3af4ca77fc3cd86765f464bb6fa7000725503257e80ccc885464b3ad43ab36c4L536-L540 not enough to do what you wanted here, is this part of the code still necessary? It seems that the previous field() alone would do what this does

Copy link
Member Author

@JoryHogeveen JoryHogeveen May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, currently only using the field method isn't enough. The field type and Pod object needs to be updated as well so traversals will work properly.
However, I do agree that this might not be the best way to do this.

@sc0ttkclark sc0ttkclark added Status: PR > Pending Code Review PR is pending code review by core developers and removed Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) labels May 19, 2021
sc0ttkclark
sc0ttkclark requested changes May 19, 2021
View reviewed changes
Copy link
Member

@sc0ttkclark sc0ttkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more discussion on the field() workaround

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.29, Pods 2.8 Aug 4, 2021
@sc0ttkclark
Copy link
Member

sc0ttkclark commented Aug 4, 2021

I recommend punting this and adding fields() support for traversal of relationship fields so that logic can be simplified

@sc0ttkclark sc0ttkclark self-assigned this Aug 17, 2021
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.8, Pods 2.9 Aug 17, 2021
@sc0ttkclark
Copy link
Member

sc0ttkclark commented Jul 25, 2022

Traversal is in Whatsit::get_field() right now, what else do we need to do here to leverage that?

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.9, Pods 3.0 Jul 25, 2022
@sc0ttkclark sc0ttkclark marked this pull request as draft July 25, 2022 14:45
@JoryHogeveen
Copy link
Member Author

JoryHogeveen commented Aug 11, 2022

@sc0ttkclark Not sure, if you say traversal is already there then maybe this PR isn't needed anymore, or can at least get a big refactor.
It's been a long time since I worked on this, I'll need to revisit what I've done.

@sc0ttkclark sc0ttkclark removed this from the Pods Unreleased/defunct milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sc0ttkclark sc0ttkclark sc0ttkclark requested changes

@jimtrue jimtrue Awaiting requested review from jimtrue

+1 more reviewer

@tr1b0t tr1b0t tr1b0t left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@sc0ttkclark sc0ttkclark

@JoryHogeveen JoryHogeveen

Labels

Keyword: Needs Unit Tests Keyword: Puntable Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pass QA passed Type: Clean up / refactor Type: Enhancement Enhancements to features that already exist, but are not major additions

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Allow recursive [if] and [else] statements

3 participants

@JoryHogeveen @sc0ttkclark @tr1b0t