Skip to content

fix(superintendent): prevent owner review from loading document MCP servers#316

Open
kamilio wants to merge 1 commit into
mainfrom
codex/fix-owner-review-to-validate-mcp-commands
Open

fix(superintendent): prevent owner review from loading document MCP servers#316
kamilio wants to merge 1 commit into
mainfrom
codex/fix-owner-review-to-validate-mcp-commands

Conversation

@kamilio
Copy link
Copy Markdown
Collaborator

@kamilio kamilio commented May 15, 2026

Motivation

  • Owner review previously forwarded MCP server definitions from superintendent document frontmatter into the spawned owner agent, creating a trust-boundary where attacker-controlled plans could cause local commands to be executed.

Description

  • Limit owner review MCP configuration to the built-in workflow transition server by changing buildMcpServers to only return the owner-workflow MCP server and ignore document-supplied MCP entries.
  • Remove the document-to-spawn MCP mapping path and the unused toSpawnMcpServer/McpConfig usage from packages/superintendent/src/runtime/run-owner-review.ts.
  • Update unit tests in packages/superintendent/src/runtime/run-owner-review.test.ts to assert that document-defined MCP servers are ignored while the workflow MCP server remains present and retains its timeout.

Testing

  • Ran npm run test -- packages/superintendent/src/runtime/run-owner-review.test.ts and the test file passed (13 tests all succeeding).
  • Commit hooks ran npm run lint:eslint and npm run lint:types as part of the commit and they completed (warnings only for existing files, no blocking errors).

Codex Task

Copy link
Copy Markdown
Contributor

@poe-code-agent poe-code-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant