-
Notifications
You must be signed in to change notification settings - Fork 12
feat: register DubboService with optional version parameter #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: register DubboService with optional version parameter #88
Conversation
...t-polaris/src/main/java/com/tencent/polaris/dubbo/metadata/report/PolarisMetadataReport.java
Show resolved
Hide resolved
| private GreetingService greetingService; | ||
|
|
||
| @DubboReference(version = "1.0.0", providedBy = "dubbo-quickstart-provider") | ||
| @DubboReference(version = "1.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么需要删除providedBy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
providedBy字段是多余的。providedBy = "dubbo-quickstart-provider"指定了使用名为dubbo-quickstart-provider的dubbo应用作为provider。启动demo的provider和consumer时,不用providedBy字段也能调用到dubbo-quickstart-provider中的服务。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
providedBy可以指定从某个被调服务获取服务信息数据,这个字段的作用可以再研究一下,填与不填的区别。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
providedBy可以指定从某个被调服务获取服务信息数据,这个字段的作用可以再研究一下,填与不填的区别。
不填写的时候,会通过mapping元数据找到提供该接口服务的全部应用,然后从北极星拉取这些应用的实例列表完成服务发现。
...t-polaris/src/main/java/com/tencent/polaris/dubbo/metadata/report/PolarisMetadataReport.java
Show resolved
Hide resolved
SkyeBeFreeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.