fix: make Behavior Event matching faster #2069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, every Behavior Event required filtering all registered behaviors to find matches. Now, we have a Behavior Index that pre-categorizes Behaviors by their `on` pattern: - `global`: Behaviors with `on: '*'` - `namespaced`: Behaviors with patterns like `on: 'select.*'` - `exact`: Behaviors with patterns like `on: 'insert.text'` Performing a Behavior Event now does O(1) map lookups instead of filtering, then merges and sorts the results to preserve priority order. The merging and sorting still allocates and iterates arrays, albeit a lot smaller. In the case of Behavior addition and removal, the index is marked as stale and then it is lazily rebuilt when the next Behavior Event is triggered. This mimics the previous caching Behavior sort order.
🦋 Changeset detectedLatest commit: ca1c313 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every Behavior Event required filtering all registered behaviors to find matches.
Now, we have a Behavior Index that pre-categorizes Behaviors by their
onpattern:global: Behaviors withon: '*'namespaced: Behaviors with patterns likeon: 'select.*'exact: Behaviors with patterns likeon: 'insert.text'Performing a Behavior Event now does O(1) map lookups instead of filtering, then merges and sorts the results to preserve priority order. The merging and sorting still allocates and iterates arrays, albeit a lot smaller.
In the case of Behavior addition and removal, the index is marked as stale and then it is lazily rebuilt when the next Behavior Event is triggered. This mimics the previous caching Behavior sort order.