Skip to content

Conversation

Copy link

Copilot AI commented Dec 9, 2025

Replaced unsafe type assertions with proper type narrowing to satisfy typescript-eslint/no-unsafe-type-assertion.

Changes

  • Check currentList.mode and newList.mode properties instead of the function parameter mode to enable TypeScript's discriminated union narrowing
  • Removed three as type assertions that were flagged as unsafe

Before:

if (mode === 'html') {
  const lastListItem = currentList.children[
    currentList.children.length - 1
  ] as ToolkitPortableTextListItem
  // ...
} else {
  ;(currentList as ToolkitPortableTextDirectList).children.push(
    newList as ToolkitPortableTextDirectList,
  )
}

After:

if (currentList.mode === 'html' && newList.mode === 'html') {
  const lastListItem = currentList.children[currentList.children.length - 1]
  // TypeScript now knows currentList is ToolkitPortableTextHtmlList
  // ...
} else if (currentList.mode === 'direct' && newList.mode === 'direct') {
  currentList.children.push(newList)
  // TypeScript now knows both are ToolkitPortableTextDirectList
}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: d6ad55c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Fix issues to enable no unsafe type assertion Fix unsafe type assertions in nestLists using discriminated union narrowing Dec 9, 2025
Copilot AI requested a review from stipsan December 9, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants