Clean up rsconnect-python deployment records on teardown - #93
Merged
Merged
Conversation
rsconnect-python writes a deployment record directory (rsconnect-python/) into the working directory during deploy. If left on disk, it can override the default server on subsequent deploys, breaking workflows that deploy to multiple Connect servers. Remove it during teardown alongside the logout step. Closes #92 Co-authored-by: Neal Richardson <2975928+nealrichardson@users.noreply.github.com>
Verifies rsconnect-python/ is removed from the fastapi fixture directory after the production deploy, per the teardown step added in 172b45f. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Preview deployed to Connect ( Deployed from commit 54be4b6. |
Contributor
|
Preview deployed to Connect ( Deployed from commit 54be4b6. |
Contributor
|
Cleaned up 1 preview bundle(s) on http://localhost:3941: 8 |
Contributor
|
Preview deployed to Connect ( Deployed from commit 54be4b6. |
Contributor
|
Cleaned up 1 preview bundle(s) on http://localhost:3942: 8 |
Contributor
|
Cleaned up 1 preview bundle(s) on http://localhost:3940: 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rsconnect-python writes a deployment record directory (
rsconnect-python/) into the working directory during deploy. If left on disk, it can override the default server on subsequent deploys, breaking workflows that deploy to multiple Connect servers. Remove it during teardown alongside the logout step.Still needs to pull in the change to the workflow listed in the issue comment.
Closes #92