feat(chat-with-content): add tested helpers and dedicated CI - #446
Open
amylin1249 wants to merge 9 commits into
Open
feat(chat-with-content): add tested helpers and dedicated CI#446amylin1249 wants to merge 9 commits into
amylin1249 wants to merge 9 commits into
Conversation
This was referenced Jul 28, 2026
Contributor
Extension release summary😴 Changed but won't releaseThe following extensions have code changes but the manifest version hasn't been incremented:
If you intended to release these changes, update the See the contributing guide for details. |
… viewers resolve_visitor_client returned the raw exception text for display when the session token exchange failed. A viewer can't act on SDK/vendor error detail, so log it server-side instead and show only the self-contained detail string.
…ings The session-exchange-timeout message was hand-written inline in app.py with different wording from NO_SESSION_DETAIL and EXCHANGE_FAILED_DETAIL, even though it's the same category of failure (can't read the viewer's session). Define it next to the other two so all three stay consistent.
uv resolved Python 3.10 locally while CI pinned 3.12 and Connect deploys 3.12.7, so contributors ran the suite on a different interpreter than either. The workflow already solved this for CI; .python-version does it for local runs, matching how the other extensions carry it (it was gitignored here). setup-uv was four majors behind and out of step with the sibling workflows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #433 into small, reviewable PRs (tracking issue #429). Stacked 1/3 — reviewable individually, merge bottom-up.
Pulls the unit-testable logic out of
app.pyintohelpers.py, adds a test suite, and gives the extension its own CI workflow. No behavior change to the app in this slice;extension.versionstays 0.0.7 (only the top of the stack bumps it).Also aligns the toolchain:
.python-versionpins the interpreter for local runs.uvwas resolving Python 3.10 locally while CI pinned 3.12 and Connect deploys 3.12.7, so the suite ran on a different interpreter than either. The workflow already solved this for CI; this does it for contributors. The file was gitignored here, unlike the other extensions that carry one, so that entry is removed too.astral-sh/setup-uvwas four majors behind (v5) and out of step with the sibling workflows; now pinned to v9.0.0.