feat(package-vulnerability-scanner): show an in-app setup screen - #456
Draft
amylin1249 wants to merge 2 commits into
Draft
feat(package-vulnerability-scanner): show an in-app setup screen#456amylin1249 wants to merge 2 commits into
amylin1249 wants to merge 2 commits into
Conversation
This was referenced Jul 29, 2026
amylin1249
force-pushed
the
pvs-04-setup-screen
branch
from
July 29, 2026 17:50
1bc19b2 to
c2fb596
Compare
Contributor
Extension release summary😴 Changed but won't releaseThe following extensions have code changes but the manifest version hasn't been incremented:
If you intended to release these changes, update the See the contributing guide for details. |
amylin1249
marked this pull request as draft
July 31, 2026 15:43
amylin1249
force-pushed
the
pvs-04-setup-screen
branch
from
August 1, 2026 01:24
c2fb596 to
283a8b2
Compare
amylin1249
force-pushed
the
pvs-04-setup-screen
branch
from
August 1, 2026 01:48
283a8b2 to
d242328
Compare
amylin1249
force-pushed
the
pvs-04-setup-screen
branch
from
August 1, 2026 03:36
d242328 to
a4b9720
Compare
amylin1249
force-pushed
the
pvs-04-setup-screen
branch
from
August 1, 2026 04:58
a4b9720 to
360c3ea
Compare
amylin1249
force-pushed
the
pvs-04-setup-screen
branch
from
August 1, 2026 05:46
360c3ea to
10f2060
Compare
When the viewer's session can't be read or the Visitor API Key integration is missing (content.ts/user.ts's setupRequired, from the previous PR), show a setup message with the specific reason instead of hanging on the loading spinner or a generic error. A separate error state still shows when something else fails to load.
…essage fallback setupRequired is only ever set on a store path that also records the error, so the default string could never render. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
amylin1249
force-pushed
the
pvs-04-setup-screen
branch
from
August 1, 2026 15:45
10f2060 to
2d1b825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #428 into small, reviewable PRs (tracking issue #415). Stacked 4/10 — stacked on #455, merge bottom-up.
When the viewer's session can't be read or the Visitor API Key integration is missing (the stores'
setupRequired, from the previous PR), the app now shows a setup message with the specific reason instead of hanging on the loading spinner or showing a generic error.The setup screen renders the reason the backend reported directly. Both stores set
erroron every path that setssetupRequired, so there is no case where the message is missing and no default string is needed.