Skip to content

fix(package-vulnerability-scanner): clear the Vite scaffold leftovers, fix deps - #461

Draft
amylin1249 wants to merge 2 commits into
pvs-08-error-surfacing-uifrom
pvs-09-security-and-misc
Draft

fix(package-vulnerability-scanner): clear the Vite scaffold leftovers, fix deps#461
amylin1249 wants to merge 2 commits into
pvs-08-error-surfacing-uifrom
pvs-09-security-and-misc

Conversation

@amylin1249

@amylin1249 amylin1249 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Split out of #428 into small, reviewable PRs (tracking issue #415). Stacked 9/10 — stacked on #460, merge bottom-up.

Sets the browser tab title and removes the leftover Vite favicon reference, adds rel="noopener" to the Package Manager footer link, and updates frontend dependencies to clear the npm audit advisories.

npm audit on this branch now reports 0 vulnerabilities, with and without --omit=dev. For reference, main reports 4 (1 moderate, 3 high): the markdown-it ReDoS, linkify-it, postcss XSS, and vite. pip-audit on requirements.txt is also clean.

requirements.txt previously named three of its four dependencies with no version at all, so a deploy could resolve a fastapi or posit-sdk older than the code expects. Floors now match pyproject.toml. These are deliberately floors rather than exact pins: pinning would freeze the set until someone bumps it, which is the wrong default for a vulnerability scanner. The file also stays hand-written rather than a uv export, since pyproject declares fastapi[standard] and exporting would bundle uvicorn/watchfiles/fastapi-cli into content that Connect already serves.

@github-actions

Copy link
Copy Markdown
Contributor

Extension release summary

😴 Changed but won't release

The following extensions have code changes but the manifest version hasn't been incremented:

  • package-vulnerability-scanner: manifest version 3.0.6 ≤ released version 3.0.6

If you intended to release these changes, update the version field in each extension's manifest.json.

See the contributing guide for details.

@amylin1249
amylin1249 marked this pull request as draft July 31, 2026 15:43
@amylin1249
amylin1249 force-pushed the pvs-09-security-and-misc branch from 5e0fe98 to 1e39795 Compare August 1, 2026 01:33
@amylin1249
amylin1249 force-pushed the pvs-09-security-and-misc branch from 1e39795 to 4b81f1c Compare August 1, 2026 01:51
@amylin1249
amylin1249 force-pushed the pvs-09-security-and-misc branch 2 times, most recently from af54532 to 4edf108 Compare August 1, 2026 04:58
@amylin1249
amylin1249 force-pushed the pvs-09-security-and-misc branch from 4edf108 to b6698c9 Compare August 1, 2026 05:27
@amylin1249
amylin1249 force-pushed the pvs-09-security-and-misc branch from b6698c9 to 5ce5549 Compare August 1, 2026 05:46
@amylin1249
amylin1249 force-pushed the pvs-09-security-and-misc branch 2 times, most recently from 4a6a9ce to c559798 Compare August 1, 2026 16:02
amylin1249 and others added 2 commits August 1, 2026 09:34
…, fix deps

Set the browser tab title to "Package Vulnerability Scanner" and remove the
leftover Vite scaffold favicon reference (/vite.svg), which 404'd because
the file isn't part of the bundle.

Set rel="noopener" on the Package Manager footer link, which opens in a new
tab with no rel at all, so the linked page can't reach back into this app
through window.opener.

npm audit fix resolves the markdown-it (ReDoS) and postcss/vite advisories
within their existing semver ranges. The one remaining high-severity
advisory (brace-expansion, via @vue/test-utils' own dependency chain) has no
non-breaking fix available upstream; it's dev-only tooling that never ships
in the deployed app.
…oors to pyproject

requirements.txt named three of its four dependencies with no version at all,
so a deploy could resolve a fastapi or posit-sdk older than the code expects.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@amylin1249
amylin1249 force-pushed the pvs-09-security-and-misc branch from c559798 to 2ce2a51 Compare August 1, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant