Skip to content

Require explicit scope for bakery update files - #753

Open
bschwedler wants to merge 1 commit into
mainfrom
require-scope-for-update-files
Open

Require explicit scope for bakery update files#753
bschwedler wants to merge 1 commit into
mainfrom
require-scope-for-update-files

Conversation

@bschwedler

Copy link
Copy Markdown
Contributor

Closes #752

Summary

bakery update files re-rendered every image and version in the project whenever --image-name and --image-version were both omitted, with no warning or confirmation. This adds a required --all flag that must be passed explicitly to render everything, mirroring the existing --matrix-versions include/exclude pattern on bakery build. Unscoped calls without --all now fail fast with a clear error instead of silently defaulting to the widest possible scope. Existing scoped calls are unaffected.

Verification

uv run bakery update files (no filters) now exits 1 with "No scope specified..."; uv run bakery update files --all renders every image/version as before. Added BDD scenarios in test/features/cli/update/files.feature covering both cases; full pytest test/cli/test_update.py suite passes.

bakery update files re-renders every image and version in the project
when no --image-name or --image-version filter is given. This is
rarely intentional and can silently touch unrelated versions across
the whole repo.

Add a required --all flag that must be passed explicitly to render
everything, mirroring the existing --matrix-versions include/exclude
pattern on bakery build. Unscoped calls without --all now fail fast
with a clear error instead of defaulting to the widest possible scope.
@github-actions

Copy link
Copy Markdown

Test Results

2 081 tests  +2   2 081 ✅ +2   8m 1s ⏱️ - 1m 57s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 5243833. ± Comparison against base commit 5693eac.

@bschwedler
bschwedler marked this pull request as ready for review August 17, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bakery update files re-renders every version with no filters and no warning

1 participant