fix: negate the result when folding 0 - x - #123
Merged
Conversation
Optimizer.fold_zeros returned the right operand unchanged for a Subtract whose left operand is the literal 0, so 0 - x folded to x and dropped the sign flip. The folded expression is now negated. Extended the existing test_fold_zeros_subtract_left assertion to check the computed value and added a column case, both of which fail without the fix. Closes posit-dev#108
Collaborator
|
Thanks for tackling this! I'll review it as soon as I can and come back to you 🙏 |
Collaborator
|
seems good! merging it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108
fold_zerosreturned the right operand unchanged for aSubtractwhose left operand is the literal0, so0 - xfolded toxand the sign flip was dropped. The folded expression is now negated.The existing
test_fold_zeros_subtract_leftonly checkedresult.op().value, which is5either way, so it passed on the buggy code; it now asserts the computed value, and a column case is added alongside it. Both fail without the source change and pass with it (tests/test_optimizer.py: 2 failed / 18 passed before, 20 passed after).This change was prepared with AI assistance; the regression test was run locally and fails without the fix.