Support normalized operands in Add and Mul - #130
Open
Johnkothapalli wants to merge 1 commit into
Open
Conversation
Collaborator
|
@Johnkothapalli there seem to be conflict with the recently shipped improvements to the Optimizer. It should not be too hard to address those, it's primarily a matter of calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphVariables.consume_operand_values(), matching Div and SubCloses #126.
Validation
uv run pytest— 364 passed, 29 skippeduv run bash examples/test_examples.sh— all 11 examples passed (Git Bash used because.shis not directly executable on Windows)uv run ruff check .— passeduv run ruff format --check .— 65 files already formatteduv run mypy— no issues in 47 source filesuv run pre-commit run -a— Ruff hooks passed; the MyPy hook could not launch on native Windows because it hard-codes.venv/bin/mypy, so the same MyPy command was run directly aboveAI assistance: Codex helped analyze the existing Div/Sub pattern, implement the change, and prepare tests. The full diff was independently reviewed and verified with the checks listed above.