feat(asides): add display="compact" for labeled asides - #326
Merged
Conversation
cpsievert
force-pushed
the
feat/numbered-labeled-asides
branch
from
August 18, 2026 16:42
1f23488 to
7c7686f
Compare
cpsievert
marked this pull request as ready for review
August 18, 2026 23:11
display="compact" for labeled asides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<shiny-aside>currently offers two useful but distinct inline presentations:+Noverflow count.That leaves no option for an aside that has meaningful label/icon, but doesn't want to show them inline. This is especially relevant for posit-dev/commons#127, where "trust pills" want to be visually distinct from "verified citations"
display="compact"fills that gap. It preserves each labeled aside's identity in the popover and accessible name, while rendering only a compact numbered marker inline. Adjacent compact asides share one marker, such as[2, 3], and continue to expose each source as a separate paged entry.What changes
display="compact"for labeled<shiny-aside>elements.Manual Smoke Test
Run
uv run shiny run sandbox/numbered_labeled_asides.py, then submit any message.Smoke app source
Screenshots
Verification
npm run builduv run pytest pkg-py/tests/playwright/chat/web_asides/test_web_asides.py -q