Skip to content

TestTestgresCommon::test_pg_ctl_wait_option is corrected #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-lipetsk merged 1 commit into from
Jan 14, 2026
Merged

TestTestgresCommon::test_pg_ctl_wait_option is corrected #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 32 additions & 5 deletions tests/test_testgres_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,13 +1247,27 @@ def test_pg_ctl_wait_option(self, node_svc: PostgresNodeService):
raise Exception("PostgresSQL did not start.")

nAttempt += 1
logging.info("------------------------ NODE #{}".format(
logging.info("------------------------ attempt #{}".format(
nAttempt
))

with __class__.helper__get_node(node_svc, port=12345) as node:
if self.impl__test_pg_ctl_wait_option(node_svc, node):
break
if nAttempt > 1:
logging.info("Sleep 3 seconds")
time.sleep(3)

port = node_svc.port_manager.reserve_port()
assert type(port) == int # noqa: E721
ok = False
try:
with __class__.helper__get_node(node_svc, port=port) as node:
if self.impl__test_pg_ctl_wait_option(node_svc, node):
ok = True
finally:
node_svc.port_manager.release_port(port)

if ok:
break

continue

logging.info("OK. Test is passed. Number of attempts is {}".format(
Expand All @@ -1272,12 +1286,25 @@ def impl__test_pg_ctl_wait_option(

C_MAX_ATTEMPTS = 50

logging.info("init node")
node.init()
assert node.status() == NodeStatus.Stopped
logging.info("node is inited")

node_log_reader = PostgresNodeLogReader(node, from_beginnig=True)

node.start(wait=False)
logging.info("start node")

try:
node.start(wait=False)
except StartNodeException as e:
logging.info("Exception ({}): {}".format(
type(e).__name__,
e,
))
return False
logging.info("node is started")

nAttempt = 0
while True:
if PostgresNodeUtils.delect_port_conflict(node_log_reader):
Expand Down