Add additional HTTP authorization types#2
Conversation
| // An application-specific authorization header, such as | ||
| // Github webhook's X-Hub-Signature-256 or X-Hub-Signature, | ||
| // *not* carried in "Authorization". | ||
| PROPRIETARY_HEADER = 11; |
There was a problem hiding this comment.
I think consumers of the IR currently assume that these authorization types are associated with the Authorization header. We'll need to weed out all the places that make this assumption.
There was a problem hiding this comment.
The conversion to/from OpenAPI2/3 will need to be updated, as well as the translation of the IR -> frontend data structures. Maybe the visitors as well, @liujed? Seems doable though.
There was a problem hiding this comment.
As I recall, parts of the GitHub comment generator will need to be updated too. Certainly doable; just need to be careful to examine all the places where we look at these values.
| // An application-specific authorization header, such as | ||
| // Github webhook's X-Hub-Signature-256 or X-Hub-Signature, | ||
| // *not* carried in "Authorization". | ||
| PROPRIETARY_HEADER = 11; |
There was a problem hiding this comment.
The conversion to/from OpenAPI2/3 will need to be updated, as well as the translation of the IR -> frontend data structures. Maybe the visitors as well, @liujed? Seems doable though.
This includes: