Security: Potential Prototype Pollution via Object Assignment#1552
Open
tomaioo wants to merge 1 commit into
Open
Security: Potential Prototype Pollution via Object Assignment#1552tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
In `lib/runner/timings.js`, the constructor uses `for (var prop in records)` without checking `hasOwnProperty`, which could lead to prototype pollution if iterate over inherited properties. While the impact is limited in this specific context, this pattern can be dangerous if `records` comes from user input. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential Prototype Pollution via Object Assignment
Problem
Severity:
Low| File:lib/runner/timings.js:L32In
lib/runner/timings.js, the constructor usesfor (var prop in records)without checkinghasOwnProperty, which could lead to prototype pollution if iterate over inherited properties. While the impact is limited in this specific context, this pattern can be dangerous ifrecordscomes from user input.Solution
Add
hasOwnPropertycheck in the for-in loop, or useObject.keys(records).forEach()instead. Consider also validating thatrecordsis a plain object before iterating.Changes
lib/runner/timings.js(modified)