Merged
Conversation
rkaminsk
requested changes
Jun 10, 2025
noxfile.py
Outdated
| session.run("mkdocs", "serve", *options) | ||
| else: | ||
| session.run("mkdocs", "build", *options) | ||
| session.error("Not longer supported, use `mkdocs serve` instead") |
Member
There was a problem hiding this comment.
I'd say, either remove it or keep it.
Collaborator
Author
There was a problem hiding this comment.
Given our discussion on how if it builds something this jobs makes no sense, I would remove it. I was just trying to make it so that if people where usedto it, they know what do now, but I guess the docs should be enough
Member
There was a problem hiding this comment.
If you think it makes no sense, just remove it. Then we can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.