Open
Conversation
simolus3
commented
Apr 23, 2026
| @override | ||
| Future<void> streamingSync() async { | ||
| assert(_abort == null); | ||
| final abort = _abort = AbortController(); |
Contributor
Author
There was a problem hiding this comment.
This ensures a _rustStreamingSyncIteration always has access to the abort controller from its iteration and avoids a bunch of non-null assertions.
| _crudLoop(); | ||
| var invalidCredentials = false; | ||
| while (!aborted) { | ||
| _state.updateStatus((s) => s.setConnectingIfNotConnected()); |
Contributor
Author
There was a problem hiding this comment.
The core extension sets connecting: true on start, so no need to replicate that.
| if (invalidCredentials) { | ||
| // This may error. In that case it will be retried again on the next | ||
| // iteration. | ||
| await connector.prefetchCredentials(); |
Contributor
Author
There was a problem hiding this comment.
I don't know what the point of this is - invalidCredentials is set on all exceptions but we also don't actually invalidate credentials? We already drop cached credentials on a 401 error, and obviously we fetch credentials when starting a connection.
But I might be missing something, so a double-check would be appreciated :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #409. Previously, there was a potential race condition when adding new sync streams because we:
AbortCurrentIterationlocal sync event.Instead of handling close events asynchronously, this refactors the control flow of the sync client, allowing us to just break out of a loop when the core extension tells us to instead of having to go through these hoops. We do this by making all instructions that won't interrupt a sync iteration extend a common class, so we can safely express which instructions we can handle in a separate methods and which ones need to be part of the loop.
This also updates the core extension and removes a workaround for a
package:httpbug related to cancelling streams on the web.