Conversation
|
Just curious, why would you want to? A major benefit of N-API is forwards compatibility. If you make a prebuild for node 8 it'll also work on 10, 12, 14 and future. |
|
Our code does not build with older versions of Node when the target is newer. See my comment here: |
Not likely, that goes against its design philosophy. Note that including more prebuilds will increase your package size. Regarding the referenced issue, there is a fix (PR welcome): #10 (comment) |
|
Well, I don't have a direct solution for #10. This PR is what I have come up with so far. |
|
For #10 we just need: if (runtime === 'node') {
// work around bug introduced in node 10's build https://github.com/nodejs/node-gyp/issues/1457
args.push('--build_v8_with_gn=false')
}Would you like to send a new PR? Thanks! |
OK. I will make a new PR, but the feature that this PR adds is separate from that issue. |
|
Could you merge this? Your suggestion is independent of what this adds. #10 is already fixed. |
|
Bump |
This makes it possible to provide
--napiand--alltogether. This means older Node versions can also be built using prebuildify.