Closed
Conversation
- Add missing require 'minitest/mock' for Minitest::Mock usage in test_declarations.rb - Replace Value.stub(:new, ...) with define_singleton_method approach since Class.stub no longer works in Ruby 3.3+ Amp-Thread-ID: https://ampcode.com/threads/T-019c8b1f-829d-70cd-83c5-3409a635e616 Co-authored-by: Amp <amp@ampcode.com>
This was referenced Feb 23, 2026
Contributor
|
thx, fixed as part of #182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two pre-existing test failures on Ruby 3.3+:
NoMethodError: undefined method 'stub' for class Value—Class.stub(:new, ...)no longer works in Ruby 3.3+. Replaced withdefine_singleton_methodto temporarily overrideValue.new.NameError: uninitialized constant Minitest::Mock—minitest/mockwas never required in the test helper.These failures affect the
test._3_3CI matrix entry and cause subsequent matrix entries to be cancelled.