chore(deps): bump deepmerge-ts and mariadb past audited vulnerabilities - #30189
Conversation
pnpm audit --prod fails on every PR with four advisories: - deepmerge-ts < 8.0.0: stack exhaustion on recursive object graphs (GHSA-ggr8-5vv4-36mx) - mariadb >= 3.4.0 < 3.4.6: cleartext password leak to a MitM despite ssl: true (GHSA-cqhc-2h57-wpxf), cleartext transmission of sensitive information (GHSA-42r5-vhpq-m858), and possible SQL injection under multibyte client charsets (GHSA-g5xc-5w98-jfvm) Bump deepmerge-ts 7.1.5 -> 8.0.2 and mariadb 3.4.5 -> 3.5.3. The mariadb 3.4.x line has no 3.4.6 release on npm; 3.5.3 is the current release that satisfies >= 3.4.6. deepmerge-ts 8 changes Map merging and deepmergeInto mutation. Neither matters here: @prisma/config only calls the basic deepmerge export on plain config objects. Signed-off-by: Oleksii Orlenko <robot@aqrln.net>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughTwo package manifests update the ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates two vulnerable dependencies and the lockfile without any supplied merge-blocking concerns; no actionable risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
size-limit report 📦
|
Summary
pnpm audit --prod(the "Run pnpm audit (production dependencies only)" step of the Lint job) fails on every PR to this branch with four advisories:deepmerge-ts< 8.0.0 — stack exhaustion on recursive object graphs (GHSA-ggr8-5vv4-36mx), highmariadb>= 3.4.0 < 3.4.6 — cleartext password leak to a MitM despitessl: true(GHSA-cqhc-2h57-wpxf, high), cleartext transmission of sensitive information (GHSA-42r5-vhpq-m858, moderate), and possible SQL injection in Buffer parameter escaping under multibyte client charsets (GHSA-g5xc-5w98-jfvm, moderate)This PR bumps:
deepmerge-ts7.1.5 → 8.0.2 inpackages/config. The v8 breaking changes are Map deep-merging and adeepmergeIntomutation fix;@prisma/configuses neither — it only calls the basicdeepmergeexport on plain config objects (loadConfigFromFile.ts). v8 still ships dual CJS/ESM.mariadb3.4.5 → 3.5.3 inpackages/adapter-mariadb. The advisories say "patched >= 3.4.6", but npm has no 3.4.6 — the 3.4.x line ends at 3.4.5; 3.5.3 is the current release satisfying the range.Lockfile updated with the repo-pinned pnpm 11.13.1.
Testing performed
pnpm audit --prodagainst the updated lockfile: "No known vulnerabilities found".pnpm --filter @prisma/config test: 4 files, 142 passed, 2 skipped — includes the config-merge tests that exercisedeepmerge.pnpm --filter @prisma/adapter-mariadb test: 45 passed.Notes for the reviewer
Summary by CodeRabbit