Open
Conversation
|
the fix contains files with the extension "cc" , but the original file are with the extension of "hh". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed the import error caused by an existing
properties.calc.jsonas described in #320. I fixed the segfault for empty force in #313. For an emptyvaluefield like this:the import will fail, but there is now an error message instead of a segfault. If
valueis missing there will also be an error message and the import will fail. The import is already successful if there is noforcefield, but now I have hardcodedforceto be always optional, so the import will work for the above JSON. This seems a bit risky - it would probably be better to pass a list of optional properties.I also updated some documentation:
import_propertiesis false by defaultadditional_filestocopy_additional_filescopy_additional_filesrequirescopy_structure_filescopy_structure_filesimpliesimport_propertiesbecause it copiesproperties.calc.jsonTwo things that I did not address are that the
copy_additional_filesoption prints every copied file to stdout, which is a lot of printing, and the documentation forcp_filessays that it returns whether or not files were copied, but I don't think that it does.