fix(finance): chart data (connected Alpaca + Yahoo fallback) + button padding#109
Merged
Merged
Conversation
…+ button padding - Charts were blank: the keyless Stooq source now returns an anti-bot challenge instead of CSV, and no app-level market-data keys are set in prod. - Prefer the user's CONNECTED Alpaca keys for candles/quotes (getActiveBrokerCreds + getMarketDataProviderForProfile), matching the keys they entered. - Add a keyless Yahoo provider (verified working) as the default + fallback, so the chart renders even if Alpaca data access fails (candles/quote routes fall back). - globals.css: the Tailwind v4 `@utility btn` lost its padding in the v3->v4 migration — restore `px-4 py-2` (+ gap-2) so all buttons aren't cramped. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Charts were blank (Stooq now bot-blocked, no prod market-data keys). Use the user's connected Alpaca keys for candles/quotes, add a keyless Yahoo provider as default+fallback, and restore button padding lost in the Tailwind v4 migration.