nodiscard ChipError Batch #21: platform-specific src: controller, android

[gmarcosb]

Summary

Batch 21 of ignored ChipError for #41629

Related issues

#41629

Testing

CI

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

• PR title is
  descriptive
• Apply the
  “When in Rome…”
  rule (coding style)
• PR size is short
• Try to avoid "squashing" and "force-update" in commit history
• CI time didn't increase

See: Pull Request Guidelines

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

[github-actions]

PR #42084: Size comparison from 4859b93 to 899e64b

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)

platform	target	config	section	4859b93	899e64b	change	% change
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	1106404	1106404	0	0.0
			RAM	178930	178930	0	0.0
bl702	lighting-app	bl702+eth	FLASH	661476	661476	0	0.0
			RAM	135025	135025	0	0.0
		bl702+wifi	FLASH	837072	837072	0	0.0
			RAM	124445	124445	0	0.0
		bl706+mfd+rpc+littlefs	FLASH	1070676	1070676	0	0.0
			RAM	117317	117317	0	0.0
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	901386	901386	0	0.0
			RAM	105788	105788	0	0.0
	lighting-app	bl702l+mfd+littlefs	FLASH	983422	983422	0	0.0
			RAM	109796	109796	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	771180	771180	0	0.0
			RAM	103360	103360	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	784008	784008	0	0.0
			RAM	108680	108680	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	729052	729052	0	0.0
			RAM	97420	97420	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	713520	713520	0	0.0
			RAM	97636	97636	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	555366	555366	0	0.0
			RAM	205776	205776	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	589150	589150	0	0.0
			RAM	206032	206032	0	0.0
efr32	lock-app	BRD4187C	FLASH	965192	965192	0	0.0
			RAM	123732	123732	0	0.0
		BRD4338a	FLASH	759520	759520	0	0.0
			RAM	254340	254340	0	0.0
	window-app	BRD4187C	FLASH	1060628	1060620	-8	-0.0
			RAM	119960	119960	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	102596	102596	0	0.0
			FLASH	1837816	1837816	0	0.0
			IRAM	93540	93540	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	934528	934528	0	0.0
			RAM	161399	161399	0	0.0
nxp	contact	mcxw71+release	FLASH	694656	694656	0	0.0
			RAM	61712	61712	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1679324	1679324	0	0.0
			RAM	213980	213980	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1594516	1594516	0	0.0
			RAM	211156	211156	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1460756	1460756	0	0.0
			RAM	197776	197776	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1494732	1494732	0	0.0
			RAM	225648	225648	0	0.0
qpg	lighting-app	qpg6200+debug	FLASH	839104	839104	0	0.0
			RAM	127920	127920	0	0.0
	lock-app	qpg6200+debug	FLASH	776316	776316	0	0.0
			RAM	118880	118880	0	0.0
realtek	light-switch-app	rtl8777g	FLASH	709256	709256	0	0.0
			RAM	107148	107148	0	0.0
	lighting-app	rtl8777g	FLASH	757960	757960	0	0.0
			RAM	127296	127296	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	470592	470592	0	0.0
			RAM	141352	141352	0	0.0
telink	bridge-app	tl7218x	FLASH	710590	710590	0	0.0
			RAM	90600	90600	0	0.0
	light-app-ota-compress-lzma-shell-factory-data	tl3218x	FLASH	797094	797094	0	0.0
			RAM	41024	41024	0	0.0
	light-app-ota-shell-factory-data	tl7218x	FLASH	788288	788288	0	0.0
			RAM	93700	93700	0	0.0
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	717154	717154	0	0.0
			RAM	52068	52068	0	0.0
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	750470	750470	0	0.0
			RAM	71108	71108	0	0.0
	light-switch-app-ota-factory-data	tl3218x_retention	FLASH	727392	727392	0	0.0
			RAM	34800	34800	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	602656	602656	0	0.0
			RAM	109648	109648	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	820900	820904	4	0.0
			RAM	92096	92096	0	0.0

[gmarcosb]

/gemini review

[gemini-code-assist]

Code Review

This pull request is part of a larger effort to handle ignored ChipError return values by adding [[nodiscard]] and then using TEMPORARY_RETURN_IGNORED to suppress warnings. The changes are mostly mechanical and correct.

However, I've identified several places where simply ignoring the return value can lead to bugs, such as crashes or deadlocks. In these cases, the error should be properly handled. I've provided suggestions to fix these issues. Please review them and consider applying the fixes.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}