Fix issue #117 Specify base go.mod for app creation#119
Open
yxuco wants to merge 4 commits intoproject-flogo:masterfrom
Open
Fix issue #117 Specify base go.mod for app creation#119yxuco wants to merge 4 commits intoproject-flogo:masterfrom
yxuco wants to merge 4 commits intoproject-flogo:masterfrom
Conversation
- Fix build to handle go mod replace correctly & do not delete shim source code after build
Contributor
|
@yxuco This feature only for specifying the version of flow and core right? We do have an option |
Author
|
--cv is not flexible enough to override other things. For example, I need to build package with shim trigger that requires patches for both flogo/core and flogo/flow versions, as well as changing the module name of the resulting package. It would be simpler to allow a startup mod file that overrides all these attributes, instead of providing multiple flags to override individual attributes such as --cv. |
Contributor
|
@mellistibco thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacein go.mod, check only lines that start with replace