Skip to content

[#106] Make sure our paths in fixtures contain utf8#161

Open
elbenfreund wants to merge 1 commit intodevelopfrom
feature/#106-Ensure_unicode_appdirs_are_ok
Open

[#106] Make sure our paths in fixtures contain utf8#161
elbenfreund wants to merge 1 commit intodevelopfrom
feature/#106-Ensure_unicode_appdirs_are_ok

Conversation

@elbenfreund
Copy link
Collaborator

in order to have confidence in our ability to handle utf8 path location
we just add random utf8 string named sub-dirs to our path fixtures.

Closes: #106

@elbenfreund
Copy link
Collaborator Author

elbenfreund commented Apr 25, 2016

It seems our code itself is perfectly able to deal with unicode paths. However, when creating an sqlachemy sqlite engine with an unicode path hamsterlib ends up generating a UnicodeError when calling repr(engine) in its attempt to write the engine name to log.
See the hamsterlib issue

In order to have confidence in our ability to handle utf8 path location
we just add random utf8 string named sub-dirs to our path fixtures.

We now have to wait for ``hamsterlib`` to fix #130

Closes: #106
@elbenfreund elbenfreund force-pushed the feature/#106-Ensure_unicode_appdirs_are_ok branch from 71d55c0 to 21135e6 Compare April 25, 2016 18:54
@codecov-io
Copy link

Current coverage is 97.33%

Merging #161 into develop will increase coverage by +<.01%

@@            develop       #161   diff @@
==========================================
  Files             3          3          
  Lines           372        374     +2   
  Methods           0          0          
  Messages          0          0          
  Branches         33         33          
==========================================
+ Hits            362        364     +2   
  Misses            6          6          
  Partials          4          4          

Sunburst

Powered by Codecov. Last updated by d4bc7ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure we can deal with UTF-8 appdir names.

2 participants