Open
Conversation
added 2 commits
May 15, 2020 18:50
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
juliusv
reviewed
May 15, 2020
content/docs/operating/security.md
Outdated
| ## Browser local storage | ||
|
|
||
| Prometheus and Alertmanager web interfaces store data in the local storage of | ||
| the web browser. The history of the queries made using the Prometheus web UI, |
Member
There was a problem hiding this comment.
Suggested change
| the web browser. The history of the queries made using the Prometheus web UI, | |
| the web browser. The history of the queries made using the Prometheus web UI |
juliusv
reviewed
May 15, 2020
content/docs/operating/security.md
Outdated
|
|
||
| Prometheus and Alertmanager web interfaces store data in the local storage of | ||
| the web browser. The history of the queries made using the Prometheus web UI, | ||
| and the creator of a silence in Alertmanager are save locally, amongst other |
Member
There was a problem hiding this comment.
Suggested change
| and the creator of a silence in Alertmanager are save locally, amongst other | |
| and the creator of a silence in Alertmanager are saved locally, amongst other |
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Member
|
👍 |
| and the creator of a silence in Alertmanager are saved locally, amongst other | ||
| data. | ||
|
|
||
| We expect that no secrets are entered into those fields and that browser |
Contributor
There was a problem hiding this comment.
Isn't this already implied by the above section on secrets?
Member
|
@roidelapluie @brian-brazil What's missing to get this merged? |
Contributor
|
My comment was never answered. |
Contributor
|
@juliusv is this section still accurate with the new UI? If so this still seems like a good addition. |
Member
|
Yeah, it's still relevant and IMO provides some good info beyond the generic Secrets section, so I'll merge it. |
Member
|
Although @roidelapluie it would require a merge conflict resolution to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu