Skip to content

Add tookit doc#1824

Draft
roidelapluie wants to merge 3 commits intoprometheus:mainfrom
roidelapluie:toolkit
Draft

Add tookit doc#1824
roidelapluie wants to merge 3 commits intoprometheus:mainfrom
roidelapluie:toolkit

Conversation

@roidelapluie
Copy link
Member

WIP

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
nanoc.yaml Outdated
items_root: /docs/toolkit/
config:
entrypoint: /introduction/
repository_url: https://github.com/roidelapluie/exporter-toolkit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a draft, I am working on my repo before branching right the tookit repo.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Copy link
Member

@grobie grobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not sure it's good idea adding yet another top-level menu item, we already have too many. Best practice is to limit the number of menu items per level to 7, to not confuse people too much. The exporter toolkit is only relevant for a very small number of people using our docs.

I'd suggest mounting the docs below Instrumenting instead. Not sure whether that requires some changes to the navigation code to allow repodocs on that level.

/docs/instrumenting/ /docs/instrumenting/clientlibs/ 302!
/docs/operating/ /docs/operating/security/ 302!
/docs/alerting/ /docs/alerting/latest/overview/ 302!
/docs/tookit/ /docs/toolkit/latest/introduction/ 302!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/docs/tookit/ /docs/toolkit/latest/introduction/ 302!
/docs/toolkit/ /docs/toolkit/latest/introduction/ 302!

@roidelapluie
Copy link
Member Author

Hm, I'm not sure it's good idea adding yet another top-level menu item, we already have too many. Best practice is to limit the number of menu items per level to 7, to not confuse people too much. The exporter toolkit is only relevant for a very small number of people using our docs.

This is the end user documentation, so the TLS config that will be used by all the exporters and Prometheus / AM / Pushgateway. it is not developers doc.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
@roidelapluie
Copy link
Member Author

I can't make the navbar to work but here is the relevant page for end users https://5fe0c8bd64952c00087ea9b1--prometheus-docs.netlify.app/docs/toolkit/latest/web-configuration/

@grobie
Copy link
Member

grobie commented Dec 21, 2020

This is the end user documentation, so the TLS config that will be used by all the exporters and Prometheus / AM / Pushgateway. it is not developers doc.

Ah, I wasn't sure what documentation you plan to publish there. Still it seems this fits well in the already existing "Instrumenting" section.

@brian-brazil
Copy link
Contributor

Currently where we have duplicated functionality (i.e. http_config) we duplicate the docs in each place in Prometheus, AM, and blackbox where it occurs.

@jan--f
Copy link
Contributor

jan--f commented Feb 17, 2026

Hello from the bug scrub!
@roidelapluie https://github.com/prometheus/exporter-toolkit is still around. This still seems worth adding, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants