fix(om2.0): fixes in type text format #2903
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the OpenMetrics 2.0 text-format specification to clarify value constraints for scalar metric types, improve cross-references/examples, and correct GaugeHistogram guidance to align with the data model (notably around Start Timestamp usage).
Changes:
- Adds explicit “Sample value MUST be a Number” statements for Gauge/Counter/Unknown in the text-format metric type sections.
- Improves spec text clarity (adds UTF-8 Quoting anchor link, refines example descriptions, adds a note about native bucket values being absolute counts).
- Adjusts GaugeHistogram text-format examples and descriptions, including removing
st@...from a GaugeHistogram example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
dashpole
previously approved these changes
Mar 18, 2026
The one major fix is that a gauge histogram doesn't have start time. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Change count and sum to `gcount` and `gsum` in the exposition for gauge histograms. This mirrors OM 1.0 suffixes. There's too many complications if we don't do this. The only downside is that the histogram functions in PromQL don't have a gauge version, but I think we can live with that. Or even add those later if anyone needs them - which I doubt. Also fix that gauge histograms model currently doesn't have start timestamp, but our text format seemed to conflict with this. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/om2-text-types
branch
from
706e548 to
32bb065
Compare
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
bwplotka
previously approved these changes
Mar 20, 2026
bwplotka
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one major fix is that a gauge histogram doesn't have start time.