Skip to content

sysfs: don't hang on cpufreq files that return EAGAIN #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blovett wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sysfs: don't hang on cpufreq files that return EAGAIN #879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sysfs/system_cpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
package sysfs

import (
"errors"
"fmt"
"os"
"path/filepath"
"strconv"
"strings"
"syscall"

"golang.org/x/sync/errgroup"

Expand Down Expand Up @@ -281,9 +283,12 @@ func parseCpufreqCpuinfo(cpuPath string) (*SystemCPUCpufreqStats, error) {
uintOut := make([]*uint64, len(uintFiles))

for i, f := range uintFiles {
v, err := parsers.ReadUintFromFile(filepath.Join(cpuPath, f))
// os.ReadFile would park forever in the netpoller if the read returns
// EAGAIN, which cpuinfo_avg_freq does on arm64 when every CPU in the
// policy is idle. Treat that as the value being unavailable.
v, err := parsers.SysReadUintFromFile(filepath.Join(cpuPath, f))
if err != nil {
if os.IsNotExist(err) || os.IsPermission(err) {
if os.IsNotExist(err) || os.IsPermission(err) || errors.Is(err, syscall.EAGAIN) {
continue
}
return &SystemCPUCpufreqStats{}, err
Expand Down