Pin SA3 to the peak-protection experiment - #103
Draft
brxs wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
9d0f559a58815ce44aa4ae5a1047f79f41090257.Why
The MLX export path currently hard-clips decoded audio. PR #90 replaces that with shared no-boost peak protection. This pin lets us manually test whether the change removes the clipping heard with LoRA generations.
Impact
The model manager will report an SA3 update and reinstall the immutable PR-head revision. The existing generation interface is unchanged.
Validation
cargo test -p lsdj-app models::tests::sa3_pin_parses