Fix/data driven pledge reward split - #28
Open
kkarrancsu wants to merge 51 commits into
Open
Conversation
adding sched expire power to metrics
adding flag to switch between using CS and AS when computing pledge
adding checks to ensure that locked does not go negative
adding tracking for available supply
adding cap for max possible qap
Add burn boost
… trajectroy is computed during the simulation. Gamma_weigthing is always arithmetic
… trajectroy is computed during the simulation. Gamma_weigthing is always arithmetic
Refactor simulation interface to default FIP-81 behavior and remove explicit gamma handling
Fix JAX 0.7.0 compatibility: resolve static argument issues
Update gamma trajectory logic and tests
…itialization The simulation initialized network_locked_pledge and network_locked_reward as a 50/50 split of locked_fil_zero. The actual Filecoin network ratio is ~90/10 (pledge/reward), causing ~5.4x over-release of locked rewards (265K FIL/day vs actual ~49K). This made simulations with <365 days of history show network_locked DECREASING (wrong direction). Fix: compute locked_reward_zero from 200 days of minting history using the actual reward locking model (locked += 0.75*reward - locked/180), then use it to initialize the pledge/reward split correctly. Changes: - data.py: add _estimate_locked_reward() helper, include in data_dict - sim.py: extract locked_reward_zero with fallback for old data_dicts - supply.py: add locked_reward_zero kwarg to both forecast and init functions All changes are backward-compatible via optional params and .get() fallbacks. See: locked-fil-split-bug-report.md (in cel/ root) for full analysis. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.