-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: return human readable error messages from lighthouse celery tasks #9165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please add an entry to the corresponding |
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
|
No changelog needed as multi-llm provider support is not rolled out in any release. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9165 +/- ##
===========================================
+ Coverage 69.31% 94.22% +24.90%
===========================================
Files 84 147 +63
Lines 5961 18644 +12683
===========================================
+ Hits 4132 17567 +13435
+ Misses 1829 1077 -752
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🔒 Container Security ScanImage: 📊 Vulnerability Summary
3 package(s) affected
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! note that change log should be adjusted accordingly.
Context
If user adds an invalid API key, the entire JSON error message is returned.
Celery task output:
Rendering the same error message on frontend looks as follows:
(As highlighted in the PR review - #8925 (comment))
Description
This PR returns just the human readable error message if the message exists in the Exception.
Steps to review
/api/v1/lighthouse/providersExample:
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.