Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separate-body cache lookups can leave file-backed response bodies open when deserialization fails, conditional headers are read, or stale/invalid responses are discarded. Close every response/body that will not be returned, while preserving open responses for fresh cache hits.
Reference issue
Fixes #497.
Tests
git diff --checkpython -m compileall -q cachecontrol/controller.py tests/test_cache_control.pycache close regressions passed).cherrypy.AI Generation Disclosure
OpenAI Codex assisted with investigation, implementation, and test drafting. I reviewed the final diff and validation output; the code and text were generated with that assistance.