Skip to content

fix: Removed backticks from migration script to fix issues with MariaDB connection type. - #5688

Merged
robertdrakedennis merged 1 commit into
pterodactyl:1.0-developfrom
Sanic5238:database-migration-fix
Jul 27, 2026
Merged

fix: Removed backticks from migration script to fix issues with MariaDB connection type.#5688
robertdrakedennis merged 1 commit into
pterodactyl:1.0-developfrom
Sanic5238:database-migration-fix

Conversation

@Sanic5238

@Sanic5238 Sanic5238 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Quick one line fix that fixes the migration failure reported in #5683

Most installs load the database/schema/mysql-schema.sql and never have to replay these migrations, since the environment variable db_connection=mariadb was set it doesn't use the squashed schema and has to replay all migrations from 2016. This connection variable is supported though it seems as per
https://github.com/pterodactyl/panel/blob/1.0-develop/config/database.php#L63 but it also defaulted above to mysql

This field was updated to include the backticks as part of 8ca0989

but I'm unable to confirm why, if I've missed something I apologize but other references in this file seem to also use the barename only this one was quoted.

Testing

Built from the current v1.14.1 release branch Dockerfile. With the schema dump removed to force a full replay for testing with the mysql database connection aswell.

  • MariaDB 11.8.8 - All migrations passed
  • MySQL - All Migrations Passed

Installs with the dump present are also unaffected by this modification.

[Apologies for bad formatting, i'm terrible with markdown]

@rowansc1

Copy link
Copy Markdown
Member

Thanks for the MR!

@Sanic5238

Sanic5238 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

heya team,
took a quick gander at the CI failures in-case i caused a linting error (somehow on a 2 character change).
seems like PR#5583 may have came through without the linter and it wants some cosmetic changes to tests/Integration/Api/Client/AccountControllerTest.php, otherwise CI will continue to fail for future PR's

@robertdrakedennis
robertdrakedennis merged commit df22fc5 into pterodactyl:1.0-develop Jul 27, 2026
1 of 9 checks passed
@lajczi

lajczi commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

#5301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants