fix: Removed backticks from migration script to fix issues with MariaDB connection type. - #5688
Merged
robertdrakedennis merged 1 commit intoJul 27, 2026
Conversation
…fix issues with mariadb migrations
Member
|
Thanks for the MR! |
Contributor
Author
|
heya team, |
robertdrakedennis
merged commit Jul 27, 2026
df22fc5
into
pterodactyl:1.0-develop
1 of 9 checks passed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick one line fix that fixes the migration failure reported in #5683
Most installs load the database/schema/mysql-schema.sql and never have to replay these migrations, since the environment variable db_connection=mariadb was set it doesn't use the squashed schema and has to replay all migrations from 2016. This connection variable is supported though it seems as per
https://github.com/pterodactyl/panel/blob/1.0-develop/config/database.php#L63 but it also defaulted above to mysql
This field was updated to include the backticks as part of 8ca0989
but I'm unable to confirm why, if I've missed something I apologize but other references in this file seem to also use the barename only this one was quoted.
Testing
Built from the current v1.14.1 release branch Dockerfile. With the schema dump removed to force a full replay for testing with the mysql database connection aswell.
Installs with the dump present are also unaffected by this modification.
[Apologies for bad formatting, i'm terrible with markdown]