Skip to content

Conversation

@phsauter
Copy link
Collaborator

@phsauter phsauter commented Dec 19, 2025

Update every IP using bender vendor.
Adjust patches accordingly, slightly clean them up.
Remove register_interface as it is no longer used (I kept APB, it is also not used but a common enough standard that I think it should remain in this repo).

@phsauter phsauter force-pushed the phsauter/update-ips branch from b1f4743 to 2c6ad7a Compare December 19, 2025 17:14
@phsauter phsauter marked this pull request as ready for review December 19, 2025 17:15
@phsauter phsauter force-pushed the phsauter/update-ips branch from 2c6ad7a to ed5b878 Compare December 19, 2025 17:34
@phsauter phsauter force-pushed the phsauter/update-ips branch from ed5b878 to a8dacf3 Compare December 19, 2025 17:38
@phsauter phsauter requested a review from ezelioli December 20, 2025 00:23
@phsauter
Copy link
Collaborator Author

@ezelioli can you give the bender files and the patch files a quick look?
Ignore the rest, it should just be generic updates.

Copy link
Contributor

@ezelioli ezelioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezelioli
Copy link
Contributor

@ezelioli can you give the bender files and the patch files a quick look? Ignore the rest, it should just be generic updates.

The only point I noticed was that it seems that we could get rid of APB dependency. But maybe it is worth keeping in the codebase in case needed by student projects?

@phsauter
Copy link
Collaborator Author

@ezelioli can you give the bender files and the patch files a quick look? Ignore the rest, it should just be generic updates.

The only point I noticed was that it seems that we could get rid of APB dependency. But maybe it is worth keeping in the codebase in case needed by student projects?

Yes, this is intentional since its a widely used standard and out of the interconnects we have, I think APB is the most likely to be used by students.
In this way is serves the purpose of making it slightly easier to add other peripherals, which is why I chose to keep it.

@phsauter phsauter merged commit 871dcef into main Dec 22, 2025
3 checks passed
@phsauter phsauter deleted the phsauter/update-ips branch December 27, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants