Skip to content

Add saml2 profile - #196

Merged
gerrod3 merged 1 commit into
pulp:mainfrom
mdellweg:saml2_profile
Jul 16, 2026
Merged

Add saml2 profile#196
gerrod3 merged 1 commit into
pulp:mainfrom
mdellweg:saml2_profile

Conversation

@mdellweg

@mdellweg mdellweg commented May 8, 2026

Copy link
Copy Markdown
Member

No description provided.

@mdellweg
mdellweg force-pushed the saml2_profile branch 3 times, most recently from 677a5c9 to fd0a155 Compare May 12, 2026 13:02
@mdellweg
mdellweg marked this pull request as ready for review May 12, 2026 14:44
Comment thread profiles/saml2/README.md Outdated
@@ -0,0 +1,3 @@
PULP_SAML_CONFIG='{saml_config}'
PULP_LOGIN_REDIRECT_URL='/pulp/default/api/v3/login/'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this only work with domains on?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so.
But after all if this points to nowhere it's more like an inconvenience. These settings serve as an example (and not even a particularly good one) for setting up SAML support.
Is there a way to make the profile more flexible?

Comment thread profiles/saml2/compose.yaml Outdated
- "/tmp/.X11-unix/:/tmp/.X11-unix/:ro"
environment:
DISPLAY: ":0.0"
default: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is default suppose to be under networks? I get this error trying to compose up this:

saml2_compose.yaml: services.browser additional properties 'default' not allowed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No i think it was supposed to default off the whole container. So you needed to start it purposefully. But that doesn't even do it, right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want a service that doesn't run automatically and needs to be specified to run, then use profiles: https://docs.docker.com/compose/how-tos/profiles/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profiles don't seem to work with oci-env now. I'm just leaving it for today.

@gerrod3

gerrod3 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@mdellweg Rebase to get green CI then I think we will be good to go.

@gerrod3
gerrod3 merged commit 7641f5f into pulp:main Jul 16, 2026
3 checks passed
@mdellweg
mdellweg deleted the saml2_profile branch July 17, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants