Skip to content

Replace black and flake with ruff #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dralley merged 1 commit into from
Jun 26, 2026
Merged

Replace black and flake with ruff #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions base/container_scripts/run_lint_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,7 @@ export XDG_CONFIG_HOME=/opt/scripts/

cd "/src/$PACKAGE/"

black --check --diff .

if [[ -f flake8.cfg ]];

@philnewm philnewm Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming flake8 commands should get replaced too as they also cause errors otherwise

/opt/oci_env/base/container_scripts/run_lint_tests.sh: line 23: flake8: command not found

then
flake8 --config flake8.cfg "${PACKAGE}"
else
flake8
fi
ruff format --check --diff
ruff check

@philnewm philnewm Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands are based on the usage in pulp_deb CI


[ ! -x .ci/scripts/extra_linting.sh ] || .ci/scripts/extra_linting.sh
Loading