This repository was archived by the owner on Mar 28, 2019. It is now read-only.
Revert "update cron interval"#162
Closed
tampakrap wants to merge 1 commit intopuppetlabs-operations:masterfrom
Closed
Revert "update cron interval"#162tampakrap wants to merge 1 commit intopuppetlabs-operations:masterfrom
tampakrap wants to merge 1 commit intopuppetlabs-operations:masterfrom
Conversation
This reverts commit 7eda4b4. The reverted commit replaced interval() with fqdn_rand(), for no clear reason. The former function though returns a list of random numbers, so we can have agent runs multiple times per hour. fqdn_rand returns only one number, thus this functionality was lost. Conflicts: manifests/agent/cron.pp
Contributor
|
it looks to me like the failed travis CI build is due to an unrelated issue: If I understand correctly, I believe the advantage to fqdn_rand is that fqdn_rand() always returns the same number on a given host, whereas interval() will generate different results each time. That said, scheduling multiple puppet runs per hour is a totally valid use case, and I think we should support it somehow. |
Contributor
Author
|
In case the desicion is not to use the interval module, then it needs to be removed from metadata.json |
Contributor
|
iirc, that was the reasoning. |
Contributor
Author
|
Closing in favor of #167 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7eda4b4.
The reverted commit replaced interval() with fqdn_rand(), for no clear reason.
The former function though returns a list of random numbers, so we can have
agent runs multiple times per hour. fqdn_rand returns only one number, thus
this functionality was lost.
Conflicts:
manifests/agent/cron.pp