feat(auth): preserve continuation through password-reset email links - #184
feat(auth): preserve continuation through password-reset email links#184altaywtf wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The README wording contradicts the shown forgotPassword example (one-arg vs two-arg usage) and should be corrected to avoid misleading consumers.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds an optional continuation URL to password-reset requests by extending the auth.forgotPassword API with a schema-validated options object, enabling the backend to include a caller-provided reset page in password-reset emails while preserving the legacy one-argument call.
Changes:
- Introduce
ForgotPasswordOptionsSchemaand extendforgotPassword(mail, options?)to sendreset_urlwhen provided. - Update auth-domain tests to cover both the legacy call and the new
resetUrloption (including invalid-input rejection). - Update promise-client adapter tests and public-surface snapshot, plus README documentation.
File summaries
| File | Description |
|---|---|
| src/domains/auth.ts | Adds options schema/type and includes reset_url in the forgot-password form body when present. |
| src/domains/auth.spec.ts | Tests the new request body behavior and validates rejection of invalid/excess option inputs. |
| src/core/client.promise.spec.ts | Updates mocked auth adapter and verifies promise client supports the new optional parameter. |
| src/snapshots/index.spec.ts.snap | Records the new exported schema in the root public surface snapshot. |
| README.md | Documents the updated forgotPassword usage with the optional resetUrl. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing after product review. The Auth rollout does not need continuation to survive the password-reset email boundary, so the optional SDK resetUrl parameter is unnecessary. The web-only reset-link redirect remains in putdotio/putio-web#1081. |
Summary
resetUrltoforgotPassword; legacy one-argument calls continue to send onlymail.Verification
vp run verifyvp run test:live,vp run test:compat, single-target live commands):reset_url.Notes
Depends on the matching backend contract; no package was published.