-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[BUGFIX] Inconsistent naming of [cross_]axis_tilt / [cross_]axis_slope
#2543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
echedey-ls
wants to merge
30
commits into
pvlib:main
Choose a base branch
from
echedey-ls:cross-axis-whatever-name-consistent-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
96697f1
Add cross_axis_tilt to nomenclature.rst
echedey-ls 8eebd5f
Rename, cross_axis_slope -> cross_axis_tilt
echedey-ls 0aa8836
Add renamed_kwarg_warning
echedey-ls 01d5c0b
Fix typo in renamed_kwarg_warning docstring
echedey-ls e72ca32
Deprecate in v0.13.1 / Removal in v0.15.0
echedey-ls 08bcde4
move descriptions, link to nomenclature term
echedey-ls 6f9da5e
Merge branch 'main' into cross-axis-whatever-name-consistent-name
echedey-ls 3ca225e
merge fix
echedey-ls c74127c
whatsnew
echedey-ls 3006aa1
Dax review
echedey-ls 2cebae7
Change: deprecate *axis_tilt in favour of *axis_slope
echedey-ls 27b24e7
Typo in v0.13.1 whatnew
echedey-ls 0b6336e
Merge branch 'main' into cross-axis-whatever-name-consistent-name
echedey-ls 3625a5a
flake8 may forgive me
echedey-ls de94021
whatsnew improvements
echedey-ls 716c880
Merge branch 'main' into cross-axis-whatever-name-consistent-name
echedey-ls 7e52234
move whatsnew entries
echedey-ls d8467bc
rm whatnew duplicated from merge entry
echedey-ls 50b1740
Merge branch 'main' into cross-axis-whatever-name-consistent-name
echedey-ls b84adc6
axis_azimuth description revision feat. cwhanse
echedey-ls 25410b3
Move definition from pvsystem's SingleAxisTrackerMount to nomenclature
echedey-ls 4c8a029
add axis_slope definition, as per figure in cross_axis_slope
echedey-ls c964df4
bump deprecation version from 0.13.1 to 0.13.2
echedey-ls 24415fd
Move Deprecations to its section, instead of Breaking Changes
echedey-ls 0350466
Description update of axis_azimuth
echedey-ls 6de2087
Merge branch 'main' into cross-axis-whatever-name-consistent-name
echedey-ls 3ed6172
picky linter
echedey-ls 30a4513
Merge branch 'cross-axis-whatever-name-consistent-name' of https://gi…
echedey-ls 5d0719a
nomenclature cross_axis_slope redaction
echedey-ls 9ecf9e4
Cliff's fixing my confusion
echedey-ls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.