Fix broken GitHub contributor links in whatsnew docs #2610
Conversation
RDaxini
left a comment
RDaxini
left a comment
There was a problem hiding this comment.
Not all of these usernames need to be deleted. Some include typos or just need to be updated if the user changed their username.
Some investigation (quick googling...) needs to be done to check each of these
| * Adam R. Jensen (:ghuser:`AdamRJensen`) | ||
| * Ioannis Sifnaios (:ghuser:`IoannisSifnaios`) | ||
| * Will Holmgren (:ghuser:`wholmgren`) | ||
| * Sophie Pelland (:ghuser:`solphie-pelland`) |
There was a problem hiding this comment.
Not all of these usernames are non-existent. For example, in this case it's just a typo
solphie should be sophie
| * Alan Mathew (:ghuser:`alamathe1`) | ||
| * Xavier Rene-Corail (:ghuser:`xcorail`) | ||
| * Anton Driesse (:ghuser:`adriesse`) | ||
| * Mark Campanelli (:ghuser:`thunderfish24`) |
There was a problem hiding this comment.
Same again, Mark's could be updated to markcampanelli
|
I will push an updated commit once all usernames are validated. |
RDaxini
left a comment
RDaxini
left a comment
There was a problem hiding this comment.
to commit the suggestions while avoiding multiple email notifications, you can go to the files changed tab and then "add suggestion to batch", and then commit all suggestions in one go—one single commit
Co-authored-by: Rajiv Daxini <[email protected]>
|
All suggested changes have been applied in a single commit. |
|
@RDaxini i have implemented the changes, it would be really helpful if you take a look at the PR!! |
|
-1 on proactively updating the GitHub user names. If a user wants to do it then sure, but not us. Many of these were made under corporate affiliations and I don't think we should take the liberty of erasing that. And the contribution list won't match the git history. |
|
was the previous approach right @wholmgren ? |
@wholmgren's point here makes sense, thanks. I think the only exception is the one typo in Sophie's username in the v0.12.0 whatsnew, but I don't know how consequential or necessary it is to fix that. |
|
+1 to fix the typo for Sophie, and not make any other changes. |
|
Issue #2489 is focused on the meaningful links that complement documentation. I just didn't bother to clean up the whole output. I will update that issue accordingly to reflect that. Please, anybody can update this PR's body so it won't close that issue automatically? TIA. |
Done |
|
should I update the PR or open a new PR? |
A new PR is easiest, I think. We agreed to changing only "solphie" to "sophie" |
|
onto it!! @cwhanse |
|
As discussed, only the “solphie” → “sophie” typo should be corrected. |
|
Completed by #2622 |
5 participants
this PR fixes multiple broken
:ghuser:links in the whatsnew contributor lists.several GitHub usernames were returning 404 errors and causing
linkcheckfailures.Fix:
:ghuser:roles while preserving contributor namesthis cleans up documentation and resolves broken external links.