Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Aug 21, 2018

  • Closes pvwatts_ac returns values less than 0 #541
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

I confirmed that the new test fails without the fix.

@wholmgren wholmgren added the bug label Aug 21, 2018
@wholmgren wholmgren added this to the 0.6.0 milestone Aug 21, 2018
@wholmgren wholmgren requested a review from cwhanse August 21, 2018 23:09
@wholmgren
Copy link
Member Author

Test failure is unrelated.

@wholmgren
Copy link
Member Author

Hearing no objections, I think we should merge... @cwhanse?

@cwhanse cwhanse merged commit 0abc6ce into pvlib:master Aug 23, 2018
@wholmgren wholmgren deleted the pvwattsdc0 branch August 28, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pvwatts_ac returns values less than 0

2 participants