Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Sep 4, 2018

  • Closes HRRR_ESRL output_variable list is wrong #557
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

@wholmgren wholmgren added the bug label Sep 4, 2018
@wholmgren wholmgren added this to the 0.6.0 milestone Sep 4, 2018
@wholmgren wholmgren merged commit 7166fb0 into pvlib:master Sep 4, 2018
@wholmgren wholmgren deleted the hrrresrl branch September 4, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants