STY: BUG: fix pvsystem imports pvlib twice #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* from pvlib import singlediode as _singlediode # to differentiate from local function pvsystem.singlediode * replace pvlib.singlediode with _singlediode everywhere * remove extra line and whitespace around FC_MODEL_PARAMS
Member
|
Thanks. I thought about doing exactly this in #559 but decided it should probably be done separately. |
Member
Author
|
Actually, you had recommended this change already in this comment on the original PR 😏
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local function pvsystem.singlediode
this should fix LGTM alert in
pvsystem.py